Skip to content

38 feat add support for co relrec relspec relsub domains#284

Merged
rubentalstra merged 4 commits intomainfrom
38-feat-add-support-for-co-relrec-relspec-relsub-domains
Jan 26, 2026
Merged

38 feat add support for co relrec relspec relsub domains#284
rubentalstra merged 4 commits intomainfrom
38-feat-add-support-for-co-relrec-relspec-relsub-domains

Conversation

@rubentalstra
Copy link
Owner

@rubentalstra rubentalstra commented Jan 25, 2026

This pull request refactors the codebase to consistently restrict mapping, preview, validation, and supplemental configuration logic to only operate on "source domains." It introduces explicit checks and conversions to ensure that these operations are not mistakenly applied to generated or non-source domains, improving correctness and maintainability. Additionally, it updates project persistence logic to only serialize source domains, preparing the codebase for future handling of generated domains.

Domain Handling Consistency

  • Updated all mapping, preview, and validation logic in domain_editor.rs to operate only on source domains by adding explicit .as_source() or .as_source_mut() checks, preventing unintended operations on other domain types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Ensured that preview and validation input structures, as well as supplemental configuration, are always sourced from the correct domain type. [1] [2]

Project Persistence Updates

  • Modified project save logic in project.rs to only persist file-based data (snapshots and assignments) for source domains, skipping generated domains and setting up for future extensibility.

Validation and Mapping State Management

  • Replaced calls to invalidate_validation() with direct manipulation of the validation_cache field for source domains, simplifying the cache invalidation process. [1] [2] [3] [4] [5] [6] [7] [8]

Export Logic Restriction

  • Updated export logic to only collect "not collected" variables from source domains, avoiding errors or irrelevant data from other domain types.

Codebase Cleanup

  • Updated imports and type usage in project.rs to support the new SourceDomainSnapshot and related structures.

@rubentalstra rubentalstra linked an issue Jan 25, 2026 that may be closed by this pull request
6 tasks
@rubentalstra rubentalstra added this to the v0.0.5-alpha milestone Jan 26, 2026
@rubentalstra rubentalstra merged commit 34486ea into main Jan 26, 2026
12 checks passed
@rubentalstra rubentalstra deleted the 38-feat-add-support-for-co-relrec-relspec-relsub-domains branch January 26, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Add support for CO, RELREC, RELSPEC, RELSUB domains

1 participant